Re: [PATCH v3 00/14] Some fixes and bunch of object_id conversions
On Wed, Jan 24, 2018 at 01:41:07PM -0800, Junio C Hamano wrote:
Show 20 quoted lines
> Patryk Obara <patryk.obara@gmail.com> writes:
>
> > Patryk Obara (14):
> > http-push: improve error log
> > clang-format: adjust penalty for return type line break
> > sha1_file: convert pretend_sha1_file to object_id
> > dir: convert struct sha1_stat to use object_id
> > sha1_file: convert hash_sha1_file to object_id
> > cache: clear whole hash buffer with oidclr
> > match-trees: convert splice_tree to object_id
> > commit: convert commit_tree* to object_id
> > notes: convert combine_notes_* to object_id
> > notes: convert write_notes_tree to object_id
> > sha1_file: convert write_sha1_file to object_id
> > sha1_file: convert force_object_loose to object_id
> > sha1_file: convert write_loose_object to object_id
> > sha1_file: rename hash_sha1_file_literally
>
> These were mostly pleasant read. I'll queue these on two topic
> branches and wait to see what others say.
Other than the one typo, looks good to me.
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
brian m. carlson <sandals@crustytoothpaste.net>