Re: [PATCH v3 0/8] Fix GIT_CEILING_DIRECTORIES that contain symlinks
- From
David Aguilar <davvid@gmail.com>
- Date
- Nov 13, 2012, 20:50 UTC
- Message-ID
- <CAJDDKr5F5EcXaTuPWgE5MZJQ=Of6MwW+RmRhhXOLyfQzanjEwQ@mail.gmail.com>
- In-Reply-To
- <7v4nkuiuhe.fsf@alter.siamese.dyndns.org>
On Mon, Nov 12, 2012 at 9:47 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes: > >> The log message of the original commit (0454dd93bf) described the >> following scenario: a /home partition under which user home directories >> are automounted, and setting GIT_CEILING_DIRECTORIES=/home to avoid >> hitting /home/.git, /home/.git/objects, and /home/objects (which would >> attempt to automount those directories). I believe that this scenario >> would not be slowed down by my patches. >> >> How do you use GIT_CEILING_DIRECTORIES that the proposed changes cause a >> slowdown? > > Yeah, I was also wondering about that. > > David?
I double-checked our configuration and all the parent directories of those listed in GIT_CEILING_DIRECTORIES are local, so our particular configuration would not have a performance hit.
We do have multiple directories listed there. Some of them share a parent directory. I'm assuming the implementation is simple and does not try and avoid repeating the check when the parent dir is the same across multiple entries.
In any case, it won't be a problem in practice based on my reading of the current code.
Show 15 quoted lines
>>> Is there another way to accomplish this without the performance hit? >>> Maybe something that can be solved with configuration? >> >> Without doing the symlink expansion there is no way for git to detect >> that GIT_CEILING_DIRECTORIES contains symlinks and is therefore >> ineffective. So the user has no warning about the misconfiguration >> (except that git runs slowly). >> >> On 10/29/2012 02:42 AM, Junio C Hamano wrote: >>> Perhaps not canonicalize elements on the CEILING list ourselves? If >>> we make it a user error to put symlinked alias in the variable, and >>> document it clearly, wouldn't it suffice? >> >> There may be no other choice. (That, and fix the test suite in another >> way to tolerate a $PWD that involves symlinks.)
-- David