git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/8] real_path_internal(): add comment explaining use of cwd

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Oct 21, 2012, 05:57 UTC
Message-ID
<1350799057-13846-3-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1350799057-13846-1-git-send-email-mhagger@alum.mit.edu>
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
 abspath.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/abspath.c b/abspath.c
index a7ab8e9..f8a526f 100644
--- a/abspath.c
+++ b/abspath.c
@@ -35,7 +35,14 @@ static const char *real_path_internal(const char *path, int die_on_error)
 {
 	static char bufs[2][PATH_MAX + 1], *buf = bufs[0], *next_buf = bufs[1];
 	char *retval = NULL;
+
+	/*
+	 * If we have to temporarily chdir(), store the original CWD
+	 * here so that we can chdir() back to it at the end of the
+	 * function:
+	 */
 	char cwd[1024] = "";
+
 	int buf_index = 1;
 
 	int depth = MAXDEPTH;
-- 
1.7.11.3
Previous: Michael HaggertyNext: Michael Haggerty
Message 3 of 26 in “Fix GIT_CEILING_DIRECTORIES that contain symlinks”
  1. 0/8 Fix GIT_CEILING_DIRECTORIES that contain symlinksMichael Haggerty, Oct 21, 2012
  2. 1/8 Introduce new static function real_path_internal()Michael Haggerty, Oct 21, 2012
  3. 2/8 real_path_internal(): add comment explaining use of cwdMichael Haggerty, Oct 21, 2012
  4. 3/8 Introduce new function real_path_if_valid()Michael Haggerty, Oct 21, 2012
  5. 4/8 longest_ancestor_length(): use string_list_split()Michael Haggerty, Oct 21, 2012
  6. 5/8 longest_ancestor_length(): take a string_list argument for prefixesMichael Haggerty, Oct 21, 2012
  7. 6/8 longest_ancestor_length(): require prefix list entries to be normalizedMichael Haggerty, Oct 21, 2012
  8. Johannes SixtOct 22, 2012
  9. 7/8 normalize_ceiling_entry(): resolve symlinksMichael Haggerty, Oct 21, 2012
  10. 8/8 string_list_longest_prefix(): remove functionMichael Haggerty, Oct 21, 2012
  11. Junio C HamanoOct 21, 2012
  12. Michael HaggertyOct 22, 2012
  13. David AguilarOct 29, 2012
  14. Junio C HamanoOct 29, 2012
  15. Michael HaggertyOct 29, 2012
  16. Junio C HamanoNov 12, 2012
  17. David AguilarNov 13, 2012
  18. Michael HaggertyNov 15, 2012
  19. Anders KaseorgFeb 20, 2013
  20. Junio C HamanoFeb 20, 2013
  21. [RFC] Provide a mechanism to turn off symlink resolution in ceiling pathsMichael Haggerty, Feb 20, 2013
  22. Junio C HamanoFeb 20, 2013
  23. Junio C HamanoFeb 21, 2013
  24. Michael HaggertyFeb 22, 2013
  25. Anders KaseorgFeb 20, 2013
  26. Lars DamerowOct 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.