git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 2/3] mergetools/kdiff3: allow opting-out of auto-merges

From
David Aguilar <davvid@gmail.com>
Date
May 10, 2013, 18:40 UTC
Message-ID
<CAJDDKr4RUzFXJpuFjCV00TE0ZmrzZzVC4uO=2uJVSxoY_==JcQ@mail.gmail.com>
In-Reply-To
<20130510054130.GA29215@hashpling.org>
On Thu, May 9, 2013 at 10:41 PM, Charles Bailey <charles@hashpling.org> wrote:
Show 21 quoted lines
> On Thu, May 09, 2013 at 03:17:30PM -0700, David Aguilar wrote:
>> Generally, "mergetool.<tool>.cmd" is not general enough since we've
>> always special cased the base vs. no-base code paths and we run
>> different commands depending on whether a base is available.
>
> Then this is a deficiency of the ".cmd" mechanism which should provide
> an "if all else fails" way to do things, even if ugly. We could simply
> add a BASELESS variable to the eval environment of the custom command.
> (Do we always create an empty file for $BASE, now?)
>
>> We could drop --auto altogether, which maybe is a better course of
>> action since it makes the behavior predictable and un-surprising, but
>> I do not know if anyone has come to rely on kdiff3's "auto-merge"
>> feature (hence the extended Cc: list).
>
> I disagree, I think that a mergetool should be allowed to be as
> helpful as possible and if it can resolve the merge unaided then this
> is no bad thing. I've worked with a number of people who were very
> happy with the current kdiff3 behaviour. Nothing prevents you from
> verifying the merge and fixing it up if it wasn't done perfectly by
> the tool, although I haven't ever encountered this with git+kdiff3.
That's the bit of info I was needing.

I can always tell the one person who ran into this that "that's how it is" and explain why it's a good thing.

"one person" < "number of people" so it's an easy decision, and we don't need to make the tool worse to cater to someone that's new to git.

Thanks Charles, -- David

Previous: Charles Bailey
Message 11 of 11 in “mergetools/kdiff3: do not use --auto when diffing”
  1. 1/3 mergetools/kdiff3: do not use --auto when diffingDavid Aguilar, May 9, 2013
  2. 2/3 mergetools/kdiff3: allow opting-out of auto-mergesDavid Aguilar, May 9, 2013
  3. 3/3 Makefile: avoid deprecation warnings on OS X 10.8David Aguilar, May 9, 2013
  4. John KeepingMay 9, 2013
  5. David AguilarMay 9, 2013
  6. Junio C HamanoMay 9, 2013
  7. John KeepingMay 9, 2013
  8. Junio C HamanoMay 9, 2013
  9. David AguilarMay 9, 2013
  10. Charles BaileyMay 10, 2013
  11. David AguilarMay 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.