Re: [RFC PATCH 3/3] Makefile: avoid deprecation warnings on OS X 10.8
- From
John Keeping <john@keeping.me.uk>
- Date
- May 9, 2013, 15:14 UTC
- Message-ID
- <20130509151436.GJ25912@serenity.lan>
- In-Reply-To
- <1368090810-40596-3-git-send-email-davvid@gmail.com>
On Thu, May 09, 2013 at 02:13:30AM -0700, David Aguilar wrote:
Show 13 quoted lines
> Mac OS X Mountain Lion prints warnings when building git: > > warning: 'SHA1_Init' is deprecated > (declared at /usr/include/openssl/sha.h:121) > > Silence the warnings by disabling OpenSSH in favor of BLK_SHA1. > > Signed-off-by: David Aguilar <davvid@gmail.com> > --- > I know I can create config.mak, but do we prefer to have the default > settings be warning-free? I do not see any other platforms that tweak > NO_OPENSSL themselves, hence "RFC". Is there a better way to do this? > Are there any Darwin/PPC users that would be harmed by this patch?
Disabling OpenSSL also has the effect of disabling SSL support in git-imap-send. Does enabling BLK_SHA1 instead also remove the warnings?
Alternatively, it seems that the recommended update is to use Apple's CommonCrypto library, as in this patch: https://gist.github.com/anonymous/4466305