git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 3/3] Makefile: avoid deprecation warnings on OS X 10.8

From
David Aguilar <davvid@gmail.com>
Date
May 9, 2013, 09:13 UTC
Message-ID
<1368090810-40596-3-git-send-email-davvid@gmail.com>
In-Reply-To
<1368090810-40596-2-git-send-email-davvid@gmail.com>
Mac OS X Mountain Lion prints warnings when building git:
	warning: 'SHA1_Init' is deprecated
	(declared at /usr/include/openssl/sha.h:121)
Silence the warnings by disabling OpenSSH in favor of BLK_SHA1.
Signed-off-by: David Aguilar <davvid@gmail.com>
---
I know I can create config.mak, but do we prefer to have the default
settings be warning-free?  I do not see any other platforms that tweak
NO_OPENSSL themselves, hence "RFC".  Is there a better way to do this?
Are there any Darwin/PPC users that would be harmed by this patch?
 Makefile | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 0f931a2..3bb9ac2 100644
--- a/Makefile
+++ b/Makefile
@@ -1055,6 +1055,7 @@ ifeq ($(uname_S),Darwin)
 		endif
 	endif
 	PTHREAD_LIBS =
+	NO_OPENSSL = YesPlease
 endif
 
 ifndef CC_LD_DYNPATH

-- 
1.8.3.rc1.38.g0f1704c
Previous: David AguilarNext: John Keeping
Message 3 of 11 in “mergetools/kdiff3: do not use --auto when diffing”
  1. 1/3 mergetools/kdiff3: do not use --auto when diffingDavid Aguilar, May 9, 2013
  2. 2/3 mergetools/kdiff3: allow opting-out of auto-mergesDavid Aguilar, May 9, 2013
  3. 3/3 Makefile: avoid deprecation warnings on OS X 10.8David Aguilar, May 9, 2013
  4. John KeepingMay 9, 2013
  5. David AguilarMay 9, 2013
  6. Junio C HamanoMay 9, 2013
  7. John KeepingMay 9, 2013
  8. Junio C HamanoMay 9, 2013
  9. David AguilarMay 9, 2013
  10. Charles BaileyMay 10, 2013
  11. David AguilarMay 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.