Re: [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Nov 2, 2026, 14:48 UTC
- Message-ID
- <CAHwyqnXtejhuPNgRgSuf-TwGcWW4AN6grp4qNkfCZCGxdYx3YQ@mail.gmail.com>
- In-Reply-To
- <auiexXLTwEIBF-HG@pks.im>
Show 14 quoted lines
> > > Granted, at times we err too much on the side of polishing the last tiny > > > nits. But quite often that's also us trying to train newcomers to write > > > proper commit histories in the first place. > > > > Yes, this is a bigger issue than I think we understand. > > > > The Pareto principle (80/20) generally holds for things like this, and > > maybe the last X% of code improvement is not worth the (100-X)% time > > investment? For sure it's not linearly distributed. > > I guess that part of the problem is also that a shallow review that > focusses on stylistic issues is way easier to do compared to one that > does a deep dive into the underlying principles. It's simply a time > tradeoff that reviewers need to do.
It's a vicious dopamine cycle.
I would probably like to see a soft rule / principle in place of no nitpicking until the idea has been settled. Nitpicking wastes precious reviewer time, and will often generate a new version, which ends up biting the reviewer again, and so on.
Harald