git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone

From
Harald Nordgren <haraldnordgren@gmail.com>
Date
Nov 2, 2026, 14:48 UTC
Message-ID
<CAHwyqnXtejhuPNgRgSuf-TwGcWW4AN6grp4qNkfCZCGxdYx3YQ@mail.gmail.com>
In-Reply-To
<auiexXLTwEIBF-HG@pks.im>
Show 14 quoted lines
> > > Granted, at times we err too much on the side of polishing the last tiny
> > > nits. But quite often that's also us trying to train newcomers to write
> > > proper commit histories in the first place.
> >
> > Yes, this is a bigger issue than I think we understand.
> >
> > The Pareto principle (80/20) generally holds for things like this, and
> > maybe the last X% of code improvement is not worth the (100-X)% time
> > investment? For sure it's not linearly distributed.
>
> I guess that part of the problem is also that a shallow review that
> focusses on stylistic issues is way easier to do compared to one that
> does a deep dive into the underlying principles. It's simply a time
> tradeoff that reviewers need to do.
It's a vicious dopamine cycle.

I would probably like to see a soft rule / principle in place of no nitpicking until the idea has been settled. Nitpicking wastes precious reviewer time, and will often generate a new version, which ends up biting the reviewer again, and so on.

Harald
Previous: Patrick SteinhardtNext: Phillip Wood
Message 17 of 26 in “object-name: explain why <ref>~N fails in a shallow clone”
  1. object-name: explain why <ref>~N fails in a shallow cloneHarald Nordgren via GitGitGadget, Sep 20, 2026
  2. D. Ben KnobleSep 20, 2026
  3. Junio C HamanoSep 21, 2026
  4. Harald NordgrenSep 21, 2026
  5. Junio C HamanoSep 21, 2026
  6. shallow: advise when a walk stops at a shallow boundaryHarald Nordgren via GitGitGadget, Sep 22, 2026
  7. Junio C HamanoSep 22, 2026
  8. object-name: explain why <rev>~N fails in a shallow cloneHarald Nordgren via GitGitGadget, Sep 23, 2026
  9. Junio C HamanoNov 2, 2026
  10. Harald NordgrenNov 2, 2026
  11. Kristoffer HaugsbakkNov 2, 2026
  12. Harald NordgrenNov 2, 2026
  13. Patrick SteinhardtNov 2, 2026
  14. Kristoffer HaugsbakkNov 2, 2026
  15. Harald NordgrenNov 2, 2026
  16. Patrick SteinhardtNov 2, 2026
  17. Harald NordgrenNov 2, 2026
  18. Phillip WoodNov 2, 2026
  19. Harald NordgrenNov 2, 2026
  20. Junio C HamanoNov 2, 2026
  21. Junio C HamanoNov 2, 2026
  22. Kristoffer HaugsbakkNov 2, 2026
  23. Harald NordgrenNov 2, 2026
  24. Patrick SteinhardtNov 2, 2026
  25. Junio C HamanoNov 2, 2026
  26. Junio C HamanoNov 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.