Re: [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Nov 2, 2026, 10:06 UTC
- Message-ID
- <CAHwyqnVzsvsGXzVj4P=rXJJTvfeQt0D39Aj7R1PTyQVkJbm4DA@mail.gmail.com>
- In-Reply-To
- <xmqqtslzlhbm.fsf@gitster.g>
On Mon, Nov 2, 2026 at 10:21 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 23 quoted lines
> > "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > From: Harald Nordgren <haraldnordgren@gmail.com> > > > > Asking for a commit's ancestor with <rev>~N in a shallow clone that > > does not have N commits of history locally fails with a bare "is not > > a commit" error, with no indication that the repository being shallow > > is the reason, or what to do about it. > > ... > > Changes in v3: > > > > * Drop the git log -<n>/--since extension entirely, per feedback that > > last commit shown is an unreliable signal for a shallow boundary. > > * Fix a bug for chained <rev>^^^ where it would print the hint twice. > > We unfortunately haven't seen many folks interested in this change. > Is anybody interested in reviewing the patch to give it a push? > > Unless we see some volunteers to give it a review in a few weeks, I > will discard the topic out of my tree, as 'seen' has been crowded > with topics that have been collecting dust without getting many > reviews.
Is it possible that maybe the review process needs to change if too many things are getting stuck? Rather than discarding acceptable work.
Harald