Re: [PATCH v3] object-name: explain why <rev>~N fails in a shallow clone
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Nov 2, 2026, 14:07 UTC
- Message-ID
- <CAHwyqnWXb6AOgK-tXzrZ5-=WYitv9iXv7N1R2JrvPJAXeCYoqg@mail.gmail.com>
- In-Reply-To
- <auiBFhXI_xiBTPbg@pks.im>
On Mon, Nov 2, 2026 at 1:25 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 22 quoted lines
> > On Mon, Nov 02, 2026 at 12:07:29PM +0100, Harald Nordgren wrote: > > > > Is it possible that maybe the review process needs to change if too > > > > many things are getting stuck? > > > > > > The regular reviewers have been talking about review work being scarce > > > compared to contributions (contributor work) for at least several years > > > now. How can this be changed if there simply aren’t enough people to > > > review everything? > > > > We can loosen the requirements on perfect code, as long as it does > > what it's supposed to and doesn't have security backdoors. > > > > Many things like tests, leaks and linting are already handled > > automatically by GitHub CI. It's a good time investment to automate > > more, because it frees up resources long-term. > > Even if we automate more of it, that would still not fix our bottleneck. > I do no trust automated reviews enough to just merge patches without a > human review, as part of the review is also the conceptual direction > that we are moving towards. And that can only really be reviewed by > someone who is familiar with the project overall.
I'm not primarily talking about the review part, but about the mechanical aspects around reviewing:
You might point out that while the tip a series builds and tests pass, a commit has a test added before the actual logic was added in the subsequent commit. This is a class of problems that we can find with automatic tooling, and then the human reviewers can free up more of their scarce time for actual reviewing.
Show 7 quoted lines
> Now automation could of course still help us. For example, if > contributors started to self-review their patch series before sending > them out, or if we had a tool like Sashiko [1]. If so, the human review > would happen on a patch series that is in a better shape already, and > that would likely require less of a time investment overall. > > [1]: https://sashiko.dev/
Interesting if Linux is using that. Linux is our sister project right? ;)
> Granted, at times we err too much on the side of polishing the last tiny > nits. But quite often that's also us trying to train newcomers to write > proper commit histories in the first place.
Yes, this is a bigger issue than I think we understand.
The Pareto principle (80/20) generally holds for things like this, and maybe the last X% of code improvement is not worth the (100-X)% time investment? For sure it's not linearly distributed.
> What I would very much like to avoid is reducing our standards just > because "carving in to AI is inevitable". I've heard that argument way > too often by now, and I don't think that it's a reasonable stance to > have. It is very much not "inevitable" that a project must move faster.
This is not my main point (although I am AI-positive).
Harald