Re: [PATCH v18 2/7] branch: convert delete_branches() to a flags argument
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Jul 10, 2026, 17:25 UTC
- Message-ID
- <CAHwyqnV6kS8ZmfXm+9JttoJ=kWP4kYdLGX2giASVMSRXVKL-Pw@mail.gmail.com>
- In-Reply-To
- <ed72dd31-5d68-4e78-9123-7061b388ecaa@gmail.com>
Show 7 quoted lines
> This means we have two sources of truth because we modify "flags" later. > The idea of replacing the old function parameters with local variables > only works if we're not passing the flags variable on to another > function so I think we should replace all instances of "force" and > "quiet" with flags & DELETE_BRANCH_FORCE/QUIET. That way we have a > single source of truth and should avoid any future regressions like the > one we saw in an earlier iteration.
Yes, it makes sense.
I just hope we remember this discussion, so another reviewer doesn't push in the other direction later because it seems like low-hanging fruit.
Harald