From: Harald Nordgren Date: Fri, 10 Jul 2026 17:25:24 GMT Subject: Re: [PATCH v18 2/7] branch: convert delete_branches() to a flags argument Message-ID: In-Reply-To: > This means we have two sources of truth because we modify "flags" later. > The idea of replacing the old function parameters with local variables > only works if we're not passing the flags variable on to another > function so I think we should replace all instances of "force" and > "quiet" with flags & DELETE_BRANCH_FORCE/QUIET. That way we have a > single source of truth and should avoid any future regressions like the > one we saw in an earlier iteration. Yes, it makes sense. I just hope we remember this discussion, so another reviewer doesn't push in the other direction later because it seems like low-hanging fruit. Harald