Re: [PATCH v18 2/7] branch: convert delete_branches() to a flags argument
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Jul 13, 2026, 15:28 UTC
- Message-ID
- <dd92c389-ba8e-4704-8464-1fcc274bb05a@gmail.com>
- In-Reply-To
- <CAHwyqnV6kS8ZmfXm+9JttoJ=kWP4kYdLGX2giASVMSRXVKL-Pw@mail.gmail.com>
Hi Harald
On 10/07/2026 18:25, Harald Nordgren wrote:
Show 13 quoted lines
>> This means we have two sources of truth because we modify "flags" later. >> The idea of replacing the old function parameters with local variables >> only works if we're not passing the flags variable on to another >> function so I think we should replace all instances of "force" and >> "quiet" with flags & DELETE_BRANCH_FORCE/QUIET. That way we have a >> single source of truth and should avoid any future regressions like the >> one we saw in an earlier iteration. > > Yes, it makes sense. > > I just hope we remember this discussion, so another reviewer doesn't > push in the other direction later because it seems like low-hanging > fruit.
If you explain why we're using flags as the source of truth, rather than replacing the function parameters with local variables in this function that should not be a problem.
Thanks
Phillip