Re: What's cooking in git.git (Aug 2020, #02; Mon, 10)

From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Aug 11, 2020, 14:27 UTC
Message-ID: <CAHd-oW7Wd8oSaMhPFeRcEeKTJ-k_hC7b6e28efhXT5LFu1E_Uw@mail.gmail.com>
In-Reply-To: <xmqqsgcub811.fsf@gitster.c.googlers.com>

Hi, Junio

On Mon, Aug 10, 2020 at 4:44 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 11 quoted lines

>
> * mt/hash-to-hex-thread-safety (2020-06-26) 2 commits
>  - hex: make hash_to_hex_algop() and friends thread-safe
>  - compat/win32/pthread: add pthread_once()
>
>  hash_to_hex() used a set of rotating static buffers, which was not
>  safe to use in a threaded environment.  This has been made safer by
>  using thread-local storage.
>
>  Expecting a reroll.
>  cf. <CAHd-oW6A2aBHg80R9kyifvF7thwzam5EYYoN9d2TaBcHJrcKWw@mail.gmail.com>

I think we can drop this one. Dscho suggested using a different approach for this conversion, with Coccinelle [1]. I won't be able to look at it right now, but if someone wants to give it a try, [2] would be a good starting point.

[1]: https://lore.kernel.org/git/nycvar.QRO.7.76.6.2007161214270.54@tvgsbejvaqbjf.bet/ [2]: https://lore.kernel.org/git/a35a9334-6db2-d8e3-8ce5-15f15a9005e1@web.de/