Re: What's cooking in git.git (Aug 2020, #02; Mon, 10)

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Aug 11, 2020, 09:59 UTC
Message-ID: <20200811095942.GG8085@camp.crustytoothpaste.net>
In-Reply-To: <20200811065347.GA1486938@coredump.intra.peff.net>

On 2020-08-11 at 06:53:47, Jeff King wrote:

Show 25 quoted lines

> diff --git a/t/t1416-ref-transaction-hooks.sh b/t/t1416-ref-transaction-hooks.sh
> index d4d19194bf..f6e741c6c0 100755
> --- a/t/t1416-ref-transaction-hooks.sh
> +++ b/t/t1416-ref-transaction-hooks.sh
> @@ -7,6 +7,7 @@ test_description='reference transaction hooks'
>  test_expect_success setup '
>  	mkdir -p .git/hooks &&
>  	test_commit PRE &&
> +	PRE_OID=$(git rev-parse PRE) &&
>  	test_commit POST &&
>  	POST_OID=$(git rev-parse POST)
>  '
> @@ -120,10 +121,10 @@ test_expect_success 'interleaving hook calls succeed' '
>  	EOF
>  
>  	cat >expect <<-EOF &&
> -		hooks/update refs/tags/PRE 0000000000000000000000000000000000000000 63ac8e7bcdb882293465435909f54a96de17d4f7
> +		hooks/update refs/tags/PRE $ZERO_OID $PRE_OID
>  		hooks/reference-transaction prepared
>  		hooks/reference-transaction committed
> -		hooks/update refs/tags/POST 0000000000000000000000000000000000000000 99d53161c3a0a903b6561b9f6c0c665b3a476401
> +		hooks/update refs/tags/POST $ZERO_OID $POST_OID
>  		hooks/reference-transaction prepared
>  		hooks/reference-transaction committed
>  	EOF

Yeah, this looks reasonable. I'm glad we've got CI working on the SHA-256 code now to catch these kinds of things.

-- 
brian m. carlson: Houston, Texas, US