git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Aug 2020, #02; Mon, 10)

From
Sergey Organov <sorganov@gmail.com>
Date
Aug 11, 2020, 21:26 UTC
Message-ID
<87lfik50xy.fsf@osv.gnss.ru>
In-Reply-To
<xmqqy2ml7wrd.fsf@gitster.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 21 quoted lines
> Sergey Organov <sorganov@gmail.com> writes:
>
>> And I asked you to postpone that in <875z9v7b0k.fsf@osv.gnss.ru> for
>> which I got no answer. I repeat it here for convenience:
>>
>> "
>> For now, can we leave these patches as-is and then add additional tests
>> on top, please? I'm afraid that adding them now will force me to rewrite
>> current descriptions, as the result won't be minimal anymore, and I
>> feel uneasy about writing commit messages for these permuted tests
>> anyway.
>> "
>
> I was expecting just one case I mentioned in the first message and
> nothing else, which is crucial to highlight how --first-parent's
> "implication" works with explicit --diff-merges.
>
> Full "permutated tests" was what you brought up in the discussion,
> but I already said it was overkill to your response before you said
> the above.  The "minimal" would be the posted patch plus a missing
> "first-parent comes before --diff-merges=off" test filled in.

I've sent the patch before I saw this, please see <87tux93pku.fsf@osv.gnss.ru>.

Is it OK with you?

Thanks, -- Sergey

Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 18 in “What's cooking in git.git (Aug 2020, #02; Mon, 10)”
  1. Junio C HamanoAug 10, 2020
  2. Eric SunshineAug 11, 2020
  3. Junio C HamanoAug 11, 2020
  4. Jeff KingAug 11, 2020
  5. Patrick SteinhardtAug 11, 2020
  6. brian m. carlsonAug 11, 2020
  7. Sergey OrganovAug 11, 2020
  8. Junio C HamanoAug 11, 2020
  9. Sergey OrganovAug 11, 2020
  10. Sergey OrganovAug 11, 2020
  11. Junio C HamanoAug 11, 2020
  12. Sergey OrganovAug 12, 2020
  13. Junio C HamanoAug 11, 2020
  14. Sergey OrganovAug 11, 2020
  15. Junio C HamanoAug 11, 2020
  16. Taylor BlauAug 11, 2020
  17. Matheus Tavares BernardinoAug 11, 2020
  18. Junio C HamanoAug 11, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.