Re: [PATCH v2 1/4] Consistently use the term "builtin" instead of "internal command"

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Jan 2, 2014, 21:05 UTC
Message-ID: <CAHGBnuO+MT4pZHD8AiQ5mFU8bDwoFSgaCyxUzL572YVstCerqA@mail.gmail.com>
In-Reply-To: <20140102203132.GQ20443@google.com>

On Thu, Jan 2, 2014 at 9:31 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 7 quoted lines

> would just leave me wondering "I never claimed it was built-in; what's
> going on?"  I think it would be simplest to keep it as
>
>         $ git whatever
>         fatal: cannot handle "whatever" internally
>
> which at least makes it clear that this is a low-level error.

Right, I'll change this in a re-roll (using single-quotes for the command name).

> The rest of the patch looks good.

Thanks for the review.

-- 
Sebastian Schuberth