git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/4] Speed up is_git_command() by checking early for internal commands

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Jan 22, 2014, 21:05 UTC
Message-ID
<52E03285.2070305@gmail.com>
In-Reply-To
<CAHGBnuNNaKNx7FzjoNhorryR5eO2c0VvbUgRc_p01mabOVr+EA@mail.gmail.com>
On 05.01.2014 14:42, Sebastian Schuberth wrote:
Show 7 quoted lines
>>> Since 2dce956 is_git_command() is a bit slow as it does file I/O in the
>>> call to list_commands_in_dir(). Avoid the file I/O by adding an early
>>> check for internal commands.
>>
>> Considering the purpose of the series is it better to say "builtin" instead of "internal" in the commit message?
>
> True, I'll fix this in a re-rool.

Sorry for not coming up with the re-roll until now, but lucky Junio has fixed this himself in c6127fa which already is on master.

-- 
Sebastian Schuberth
Previous: Sebastian SchuberthNext: Sebastian Schuberth
Message 13 of 16 in “[PATCH v2 0/4]”
  1. 0/4 Sebastian Schuberth, Jan 2, 2014
  2. 1/4 Consistently use the term "builtin" instead of "internal command"Sebastian Schuberth, Jan 2, 2014
  3. Jonathan NiederJan 2, 2014
  4. Sebastian SchuberthJan 2, 2014
  5. Sebastian SchuberthJan 22, 2014
  6. 2/4 Call load_command_list() only when it is neededSebastian Schuberth, Jan 2, 2014
  7. 3/4 Speed up is_git_command() by checking early for internal commandsSebastian Schuberth, Jan 2, 2014
  8. Junio C HamanoJan 2, 2014
  9. Jeff KingJan 3, 2014
  10. Junio C HamanoJan 3, 2014
  11. Kent R. SpillnerJan 3, 2014
  12. Sebastian SchuberthJan 5, 2014
  13. Sebastian SchuberthJan 22, 2014
  14. 4/4 Move builtin-related implementations to a new builtin.c fileSebastian Schuberth, Jan 2, 2014
  15. Junio C HamanoJan 2, 2014
  16. Sebastian SchuberthJan 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.