Re: [PATCH v2 4/4] Move builtin-related implementations to a new builtin.c file

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Jan 2, 2014, 20:58 UTC
Message-ID: <CAHGBnuMathrjUt10AqnEP=d4b306=+D4DFhPeDX0zmpsniA-rg@mail.gmail.com>
In-Reply-To: <xmqqy52yp3tm.fsf@gitster.dls.corp.google.com>

On Thu, Jan 2, 2014 at 8:43 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

>>  Documentation/technical/api-builtin.txt |   2 +-
>>  Makefile                                |   1 +
>>  builtin.c                               | 225 ++++++++++++++++++++++++++++++
>>  builtin.h                               |  21 +++
>>  git.c                                   | 238 --------------------------------
>>  5 files changed, 248 insertions(+), 239 deletions(-)
>>  create mode 100644 builtin.c
>
> I'm sorry but I do not see a point in this.
>
> It is not like builtin.c can be used outside the context of the main
> Git program, and many helper functions you moved out of git.c that
> used to be static want to be called from other places.

I've added this commit because Christian suggested so in [1], and also because it has always bothered me that the Git project does not define a function in a file named after the header file that declares the function. Anyway, I've made this the last commit in the series on purpose, I can just drop it in the next re-roll.

[1] http://www.spinics.net/lists/git/msg222452.html.

-- 
Sebastian Schuberth