git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 8/9] submodule: fix handling of denormalized superproject origin URLs

From
Jon Seymour <jon.seymour@gmail.com>
Date
May 27, 2012, 14:38 UTC
Message-ID
<CAH3Anro5nLmP_e3AGj42FoDr9Xt+ADd4KUF9sb+AzKsh7V-5Aw@mail.gmail.com>
In-Reply-To
<1338126210-11517-9-git-send-email-jon.seymour@gmail.com>
On Sun, May 27, 2012 at 11:43 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
Show 10 quoted lines
> This change also fixes a subtle error in the setup of t7403 which was
> masked by the denormalization issue. Previous behaviour was
> relying on submodule add to clone trash/submodule into super/submodule,
> however from the perspective of super's origin (i.e. trash), the origin
> submodule is actually located at ./submodule not ../submodule. However,
> because the origin URL of super was denormalized (it had a trailing /.)
> the incorrect handling of denormalized super URLs actually produced
> the correct result - a case of two errors cancelling out each other's
> effects.
>

Forgot to check the other test scripts for a similar issue. This change breaks the following tests:

   t7406-submodule-update.sh
   t7407-submodule-foreach.sh
   t7506-status-submodule.sh
possibly because of the same issue mentioned in regard to t7403.

In any case, better not to apply this to pu until I have had a chance to re-roll a v7

jon.
Previous: Jon SeymourNext: Jon Seymour
Message 11 of 12 in “submodule: improve robustness of path handling”
  1. 0/9 submodule: improve robustness of path handlingJon Seymour, May 27, 2012
  2. 1/9 submodule: additional regression tests for relative URLsJon Seymour, May 27, 2012
  3. 2/9 submodule: document failure to detect invalid submodule URLsJon Seymour, May 27, 2012
  4. 3/9 submodule: document failure to handle relative superproject origin URLsJon Seymour, May 27, 2012
  5. 4/9 submodule: document failure to handle improperly normalized remote origin URLsJon Seymour, May 27, 2012
  6. 5/9 submodule: extract normalize_path into standalone functionJon Seymour, May 27, 2012
  7. 6/9 submodule: fix detection of invalid submodule URLJon Seymour, May 27, 2012
  8. 7/9 submodule: fix sync handling of relative superproject origin URLsJon Seymour, May 27, 2012
  9. Jon SeymourMay 27, 2012
  10. 8/9 submodule: fix handling of denormalized superproject origin URLsJon Seymour, May 27, 2012
  11. Jon SeymourMay 27, 2012
  12. 9/9 submodule: fix normalization to handle repeated ./Jon Seymour, May 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.