git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 0/9] submodule: improve robustness of path handling

From
Jon Seymour <jon.seymour@gmail.com>
Date
May 27, 2012, 13:43 UTC
Message-ID
<1338126210-11517-1-git-send-email-jon.seymour@gmail.com>
This series improves the robustness of path handling by 'git submodule' by:
* detecting submodule URLs that will result in non-sensical submodule origin URLs
* improving handling of various kinds of relative superproject origin URLs
* improving handling of various kinds of denormalized superproject origin URLs
This series differs from v5 in the following ways, by:
* Adding a more extensive set of failure tests to illustrate the conditions 
being addressed.
* Modifying the ../ processing loop in resolve_relative_url to exclude the 
'invariant' parts of absolute URLs from relative URL processing and thereby 
enable earlier and more accurate detection of edits that are going to 
produce a non-sensical output.
* Simplifying relative superproject origin URL support, by taking advantage of
the modifications above.
* Adding support for normalizing denormalized superproject origin URLs.
* Adding some additional regression tests to help guard against 
unintended regressions by this series.
* Improving the source code comments to better explain the purpose
of various code functions and code blocks
Jon Seymour (9):
  submodule: additional regression tests for relative URLs
  submodule: document failure to detect invalid submodule URLs
  submodule: document failure to handle relative superproject origin
    URLs
  submodule: document failure to handle improperly normalized remote
    origin URLs
  submodule: extract normalize_path into standalone function
  submodule: fix detection of invalid submodule URL
  submodule: fix sync handling of relative superproject origin URLs
  submodule: fix handling of denormalized superproject origin URLs
  submodule: fix normalization to handle repeated ./
 git-submodule.sh           | 118 +++++++++++++-----
 t/t7400-submodule-basic.sh | 297 ++++++++++++++++++++++++++++++++++++++++++++-
 t/t7403-submodule-sync.sh  |  84 ++++++++++++-
 3 files changed, 468 insertions(+), 31 deletions(-)
-- 
1.7.10.2.656.gb5a46db
Next: Jon Seymour
Message 1 of 12 in “submodule: improve robustness of path handling”
  1. 0/9 submodule: improve robustness of path handlingJon Seymour, May 27, 2012
  2. 1/9 submodule: additional regression tests for relative URLsJon Seymour, May 27, 2012
  3. 2/9 submodule: document failure to detect invalid submodule URLsJon Seymour, May 27, 2012
  4. 3/9 submodule: document failure to handle relative superproject origin URLsJon Seymour, May 27, 2012
  5. 4/9 submodule: document failure to handle improperly normalized remote origin URLsJon Seymour, May 27, 2012
  6. 5/9 submodule: extract normalize_path into standalone functionJon Seymour, May 27, 2012
  7. 6/9 submodule: fix detection of invalid submodule URLJon Seymour, May 27, 2012
  8. 7/9 submodule: fix sync handling of relative superproject origin URLsJon Seymour, May 27, 2012
  9. Jon SeymourMay 27, 2012
  10. 8/9 submodule: fix handling of denormalized superproject origin URLsJon Seymour, May 27, 2012
  11. Jon SeymourMay 27, 2012
  12. 9/9 submodule: fix normalization to handle repeated ./Jon Seymour, May 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.