From: Jon Seymour <jon.seymour@gmail.com>
Date: Sun, 27 May 2012 14:38:17 GMT
Subject: Re: [PATCH v6 8/9] submodule: fix handling of denormalized superproject origin URLs
Message-ID: <CAH3Anro5nLmP_e3AGj42FoDr9Xt+ADd4KUF9sb+AzKsh7V-5Aw@mail.gmail.com>
In-Reply-To: <1338126210-11517-9-git-send-email-jon.seymour@gmail.com>

On Sun, May 27, 2012 at 11:43 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
> This change also fixes a subtle error in the setup of t7403 which was
> masked by the denormalization issue. Previous behaviour was
> relying on submodule add to clone trash/submodule into super/submodule,
> however from the perspective of super's origin (i.e. trash), the origin
> submodule is actually located at ./submodule not ../submodule. However,
> because the origin URL of super was denormalized (it had a trailing /.)
> the incorrect handling of denormalized super URLs actually produced
> the correct result - a case of two errors cancelling out each other's
> effects.
>

Forgot to check the other test scripts for a similar issue. This
change breaks the following tests:

   t7406-submodule-update.sh
   t7407-submodule-foreach.sh
   t7506-status-submodule.sh

possibly because of the same issue mentioned in regard to t7403.

In any case, better not to apply this to pu until I have had a chance
to re-roll a v7

jon.