Re: [PATCH 5/6] fetch-pack: move common check and marking together

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jun 6, 2018, 02:12 UTC
Message-ID: <CAGf8dgLsP6MWSd9OTL7tq+92Rh8UA9Kitzn6nCiRj1bM+Eyk4Q@mail.gmail.com>
In-Reply-To: <20180606000146.GH9266@aiede.svl.corp.google.com>

On Tue, Jun 5, 2018 at 5:01 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 11 quoted lines

> I like it.  I think it should be possible to describe the benefit of
> this patch without reference to the specifics of the subsequent one.
> Maybe something like:
>
>         When receiving 'ACK <object-id> continue' for a common commit,
>         check if the commit was already known to be common and mark it
>         as such if not up front.  This should make future refactoring
>         of how the information about common commits is stored more
>         straightforward.
>
>         No visible change intended.

Thanks, I'll use your suggestion.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.