From: Jonathan Tan <jonathantanmy@google.com>
Date: Wed, 06 Jun 2018 02:12:46 GMT
Subject: Re: [PATCH 5/6] fetch-pack: move common check and marking together
Message-ID: <CAGf8dgLsP6MWSd9OTL7tq+92Rh8UA9Kitzn6nCiRj1bM+Eyk4Q@mail.gmail.com>
In-Reply-To: <20180606000146.GH9266@aiede.svl.corp.google.com>

On Tue, Jun 5, 2018 at 5:01 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> I like it.  I think it should be possible to describe the benefit of
> this patch without reference to the specifics of the subsequent one.
> Maybe something like:
>
>         When receiving 'ACK <object-id> continue' for a common commit,
>         check if the commit was already known to be common and mark it
>         as such if not up front.  This should make future refactoring
>         of how the information about common commits is stored more
>         straightforward.
>
>         No visible change intended.

Thanks, I'll use your suggestion.