Re: [PATCH 5/6] fetch-pack: move common check and marking together

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 6, 2018, 00:01 UTC
Message-ID: <20180606000146.GH9266@aiede.svl.corp.google.com>
In-Reply-To: <02577402adaf0d109f74e59486d8a23f6ae68663.1527894919.git.jonathantanmy@google.com>

Hi,

Jonathan Tan wrote:

> This enables the calculation of was_common and the invocation to
> mark_common() to be abstracted into a single call to the negotiator API
> (to be introduced in a subsequent patch).

I like it. I think it should be possible to describe the benefit of this patch without reference to the specifics of the subsequent one. Maybe something like:

	When receiving 'ACK <object-id> continue' for a common commit,
	check if the commit was already known to be common and mark it
	as such if not up front.  This should make future refactoring
	of how the information about common commits is stored more
	straightforward.

	No visible change intended.

> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
>  fetch-pack.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

With or without such a clarification,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.