git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9101: Refactor test_expect_success format

From
Seyi Chamber <kuforiji98@gmail.com>
Date
Nov 1, 2024, 07:51 UTC
Message-ID
<CAGedMteyi0_C4PhfCXcD5gHe38px_g4hbxuG63o8tCSHdLcfGg@mail.gmail.com>
In-Reply-To
<ZyPlYkwsFrxH+JwE@nand.local>
On Thu, 31 Oct 2024 at 21:15, Taylor Blau <me@ttaylorr.com> wrote:
Show 12 quoted lines
>
> On Thu, Oct 31, 2024 at 10:45:53AM +0100, Seyi Kuforiji wrote:
> > The current script uses an outdated formatting style for
> > test_expect_success blocks, where each argument is separated by a
> > backslash and newline. This style can lead to readability issues and
> > makes it harder to maintain the script.
> >
> > The modern style consolidates
> > the multi-line command arguments into a single quoted block, which
>
> Strange line wrapping?
>

That error probably occurred while I was editing the message. Should I edit and send an updated patch?

Show 16 quoted lines
> > improves readability, maintainability, and aligns the code with current
> > coding standards.
> >
> > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> > ---
> >  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------
> >  1 file changed, 26 insertions(+), 22 deletions(-)
>
> This does not apply cleanly on 'master', so I assume that you wanted it
> based on sk/t9101-cleanup. That's fine, but please let me know in the
> future in case it's every less obvious :-).
>
> The changes themselves all look quite sensible, though.
>
> Thanks,
> Taylor

Thanks, Taylor for pointing out this issue. I have rebased my change onto the latest master branch and resolved the conflicts for future updates.

Thanks, Seyi

Previous: Taylor BlauNext: Taylor Blau
Message 3 of 6 in “t9101: Refactor test_expect_success format”
  1. t9101: Refactor test_expect_success formatSeyi Kuforiji, Oct 31, 2024
  2. Taylor BlauOct 31, 2024
  3. Seyi ChamberNov 1, 2024
  4. Taylor BlauNov 1, 2024
  5. t9101: Refactor test_expect_success formatSeyi Kuforiji, Nov 2, 2024
  6. Seyi ChamberNov 18, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.