Re: [PATCH 3/5] setup_revisions: remember whether a ref was positive or not

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Aug 8, 2011, 23:25 UTC
Message-ID: <CAGdFq_hO-MYC_kXZZhoqXhTRvVhCDfTT4EHPoYDyHjGtRiSB9g@mail.gmail.com>
In-Reply-To: <7vy5z3trwu.fsf@alter.siamese.dyndns.org>

Heya,

On Tue, Aug 9, 2011 at 01:17, Junio C Hamano <gitster@pobox.com> wrote:

> Yes, I am that user who have been disturbed by the command line revision
> parser limitation for a loooooooong time and have been wanting to see it
> properly fixed for quite a while (by myself or by somebody else).

Aaaah, well that does explain a thing or two :).

> Seeing a single-bit "hack" not
> from a complete newbie but from two known-to-be-competent long timers of
> Git is another.

Perhaps known-to-be-competent, but time-constrained nonetheless. Sometimes one is forced to chose between fixing something you care about and doing something in a non-hacky way... There's only so much time in a day to work on side-projects such as this after all :).

Show 7 quoted lines

> There are numerous hacks that try to work around the same revision parser
> limitation (lossage of information), and I have been hoping that a series
> that touch the parser to leave more information during parsing to be
> cleanly enhancible to get rid of them (e.g. "git checkout $commit" vs "git
> checkout $branch" looks at the command line itself, but it should be able
> to call into the revision parser and inspect what the parser gives it
> back).

Ok, knowing that, I am somewhat more inclined to have a look at this. I'm still not sure that I know how to implement the design you described though. I mean, I understand the general concept, but I have no idea in what places it would need to hook in to make it work (ditto on how to fix the diff bug).

-- 
Cheers,

Sverre Rabbelier