Re: [PATCH 3/5] setup_revisions: remember whether a ref was positive or not

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2011, 22:07 UTC
Message-ID: <7vty9rv9p2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAGdFq_hLy6_AW-Yh_9fi318Z6jdkFWw5+cYrwMtOitDkGQorFA@mail.gmail.com>

Sverre Rabbelier <srabbelier@gmail.com> writes:

> Nobody needs the stuff you mentioned right now.

Wrong.

"diff ^C A B" is a bug, isn't it? And that is a bug in the current code.

Show 7 quoted lines

>> I would be reluctant to accept a myopic hack that is only good for one
>> caller and that needs to be ripped out and re-done, especially when we
>> already know other issues that can be solved cleanly if you go a little
>> further in the initial round.
>
> While I understand this reluctance, remember that this "one caller" is
> required to fix a bug in the current code.