Re: [PATCH 3/5] setup_revisions: remember whether a ref was positive or not

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2011, 22:56 UTC
Message-ID: <7vd3gfv7gd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAGdFq_jzraS-_afjs+MmRS4ML805h73hXAjrRkrQ=tGUdSQqkQ@mail.gmail.com>

Sverre Rabbelier <srabbelier@gmail.com> writes:

Show 12 quoted lines

>> Please remind yourself why then it is not sufficient for your patch to
>> read from the name field please?
>
> Sure, we could do it. But it would be duplicating all the effort
> already being done in rev-parse!
>
>> After all, wasn't the issue that "master^0..master" yields an empty set
>> but you somehow wanted to know that the RHS of that dotdot was given as a
>> positive ref?
>
> The issue was that if I push "master" to origin but I already pushed a
> "next" which points at the same commit nothing happens...

Would we have the same issue with "git bundle", by the way, caused by the same setup_revisions() limitation? Over there we would also need to decide the set of refs that the user wanted to record their values while computing the set of commits we would need to transfer.

In this message I am not interested in talking about what implementation to use to fix it, but just wondering the scope of the same issue and trying to figure out the (positive) impact of _a_ fix.