git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH v4] t2027: avoid using pipes

From
Stefan Beller <sbeller@google.com>
Date
Apr 3, 2017, 19:40 UTC
Message-ID
<CAGZ79kbmriQoJgjF0-Kv1QzU2NWn=2EGN10CbNTKYO4zCBMFaA@mail.gmail.com>
In-Reply-To
<20170324120433.2890-1-pc44800@gmail.com>
On Fri, Mar 24, 2017 at 5:04 AM, Prathamesh Chavan <pc44800@gmail.com> wrote:
Show 5 quoted lines
> Whenever a git command is present in the upstream of a pipe, its failure
> gets masked by piping and hence it should be avoided for testing the
> upstream git command. By writing out the output of the git command to
> a file, we can test the exit codes of both the commands as a failure exit
> code in any command is able to stop the && chain.

Sorry for dropping the ball here. This patch is identical in code that Torsten reviewed and has a slight grammar fix in the commit message.

> Signed-off-by: Prathamesh Chavan <pc44800@gmail.com>
I reviewed the patch it it looks fine.

Thanks, Stefan

Previous: Prathamesh ChavanNext: Prathamesh Chavan
Message 12 of 13 in “t2027: avoid using pipes”
  1. t2027: avoid using pipesPrathamesh Chavan, Mar 9, 2017
  2. Christian CouderMar 9, 2017
  3. t2027: avoid using pipesPrathamesh Chavan, Mar 10, 2017
  4. Junio C HamanoMar 13, 2017
  5. t2027: avoid using pipespc44800@gmail.com, Mar 13, 2017
  6. t2027: avoid using pipesPrathamesh, Mar 13, 2017
  7. PrathameshMar 22, 2017
  8. Christian CouderMar 23, 2017
  9. [GSoC][PATCH v4] t2027: avoid using pipesPrathamesh Chavan, Mar 24, 2017
  10. Torsten BögershausenMar 24, 2017
  11. [GSoC][PATCH v4] t2027: avoid using pipesPrathamesh Chavan, Mar 24, 2017
  12. Stefan BellerApr 3, 2017
  13. [GSoC][PATCH v5] t2027: avoid using pipesPrathamesh Chavan, Apr 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.