From: Stefan Beller Date: Mon, 03 Apr 2017 19:40:20 GMT Subject: Re: [GSoC][PATCH v4] t2027: avoid using pipes Message-ID: In-Reply-To: <20170324120433.2890-1-pc44800@gmail.com> On Fri, Mar 24, 2017 at 5:04 AM, Prathamesh Chavan wrote: > Whenever a git command is present in the upstream of a pipe, its failure > gets masked by piping and hence it should be avoided for testing the > upstream git command. By writing out the output of the git command to > a file, we can test the exit codes of both the commands as a failure exit > code in any command is able to stop the && chain. Sorry for dropping the ball here. This patch is identical in code that Torsten reviewed and has a slight grammar fix in the commit message. > Signed-off-by: Prathamesh Chavan I reviewed the patch it it looks fine. Thanks, Stefan