Re: [PATCH v3] t2027: avoid using pipes

From: Christian Couder <christian.couder@gmail.com>
Date: Mar 23, 2017, 10:15 UTC
Message-ID: <CAP8UFD3xOMbXgH5JATS7-cK_d0YA7Mvkk-ZpLh8sn-KYNm3wxg@mail.gmail.com>
In-Reply-To: <20170313065148.10707-1-pc44800@gmail.com>

Please add something like [GSoC] in the subject so that it is easy for us to find GSoC related patches.

On Mon, Mar 13, 2017 at 7:51 AM, Prathamesh <pc44800@gmail.com> wrote:

> Whenever a git command is present in the upstream of a pipe, its failure
> gets masked by piping and hence it should be avoided for testing the
> upstream git command. By writing out the output of the git command to
> a file, we can test the exit codes of both the commands as a failure exit

Maybe: s/the commands/commands/

> code in any command is able to stop the && chain.

Maybe: s/is able to/will/

> Signed-off-by: Prathamesh <pc44800@gmail.com>
> ---
> Changed sendemail.name configuration of the .gitconfig file with a single
> name,

About that, please note that in Documentation/SubmittingPatches there is:

"Also notice that a real name is used in the Signed-off-by: line. Please don't hide your real name."

So my opinion on this is that it would be better with your full name instead of just one of your names.

> and also included the leftover files of each test to be removed by
> test_when_finished if the test is passed successfully.

Ok.

You could also here tell us (again) that it is your GSoC microproject. It would help if we are searching microproject related patches.

>  t/t2027-worktree-list.sh | 35 +++++++++++++++++++++--------------
>  1 file changed, 21 insertions(+), 14 deletions(-)

Otherwise it looks good to me.