Re: [PATCH] transport: report missing submodule pushes consistently on stderr

From: Stefan Beller <sbeller@google.com>
Date: Aug 24, 2016, 16:35 UTC
Message-ID: <CAGZ79kb1ur=s+FYcdCh+obKyfaozX=adAPESu9G9FQxVtLTDbg@mail.gmail.com>
In-Reply-To: <20160824122828.0c2688e8@labs-064.localdomain>

On Wed, Aug 24, 2016 at 3:28 AM, Leandro Lucarella <leandro.lucarella@sociomantic.com> wrote:

Show 21 quoted lines

> On Tue, 23 Aug 2016 14:40:08 -0700
> Stefan Beller <sbeller@google.com> wrote:
>> The surrounding advice is printed to stderr, but the list of
>> submodules is not. Make the report consistent by reporting everything
>> to stderr.
>>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>>
>>   This fixes one of the bugs mentioned in
>>   https://public-inbox.org/git/CAGZ79kbkyupBJfvyX3Hj_R5ZW36+3ufOnnLC-Dpic40nPJAxDA@mail.gmail.com/T/#t
>>
>>   How to fix the other was not as obvious to me as I do not
>> understand the philosophy on verbosity in the transport code.
>
> I had a look and I would say just enclose all the fprintf() inside a:
>
>         if (transport->verbose > 0)
>
> But then this is the first time I look at the code. I was about to send
> a patch too but it will conflict with this one :)

Well you can still send a patch :)

We have

    int verbose = (transport->verbose > 0);
    int quiet = (transport->verbose < 0);

So you're suggesting to only print these warnings when the user asked for explicit verbose?

A few lines before the call to die_with_unpushed_submodules we have

     die ("Failed to push all needed submodules!");

which would also need a wrapping like

    if (quiet)
        return -1;
    else
        die(...);

Thanks, Stefan