Re: [PATCH] transport: report missing submodule pushes consistently on stderr

From: Leandro Lucarella <leandro.lucarella@sociomantic.com>
Date: Aug 24, 2016, 10:28 UTC
Message-ID: <20160824122828.0c2688e8@labs-064.localdomain>
In-Reply-To: <20160823214008.32331-1-sbeller@google.com>

On Tue, 23 Aug 2016 14:40:08 -0700 Stefan Beller <sbeller@google.com> wrote:

Show 12 quoted lines

> The surrounding advice is printed to stderr, but the list of
> submodules is not. Make the report consistent by reporting everything
> to stderr.
> 
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> 
>   This fixes one of the bugs mentioned in
>   https://public-inbox.org/git/CAGZ79kbkyupBJfvyX3Hj_R5ZW36+3ufOnnLC-Dpic40nPJAxDA@mail.gmail.com/T/#t
>   
>   How to fix the other was not as obvious to me as I do not
> understand the philosophy on verbosity in the transport code.

I had a look and I would say just enclose all the fprintf() inside a:

	if (transport->verbose > 0)

But then this is the first time I look at the code. I was about to send a patch too but it will conflict with this one :)

Anyway, thanks for the quick fix to the inconsistent printing with --quiet.

-- 
Leandro Lucarella
Technical Development Lead
Sociomantic Labs GmbH <http://www.sociomantic.com>