[PATCH] transport: report missing submodule pushes consistently on stderr
- From
Stefan Beller <sbeller@google.com>
- Date
- Aug 23, 2016, 21:40 UTC
- Message-ID
- <20160823214008.32331-1-sbeller@google.com>
The surrounding advice is printed to stderr, but the list of submodules is not. Make the report consistent by reporting everything to stderr.
Signed-off-by: Stefan Beller <sbeller@google.com> ---
This fixes one of the bugs mentioned in https://public-inbox.org/git/CAGZ79kbkyupBJfvyX3Hj_R5ZW36+3ufOnnLC-Dpic40nPJAxDA@mail.gmail.com/T/#t How to fix the other was not as obvious to me as I do not understand the philosophy on verbosity in the transport code. Thanks, Stefan
transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/transport.c b/transport.c index cf8de6e..94d6dc3 100644 --- a/transport.c +++ b/transport.c @@ -771,7 +771,7 @@ static void die_with_unpushed_submodules(struct string_list *needs_pushing) fprintf(stderr, _("The following submodule paths contain changes that can\n" "not be found on any remote:\n")); for (i = 0; i < needs_pushing->nr; i++) - printf(" %s\n", needs_pushing->items[i].string); + fprintf(stderr, " %s\n", needs_pushing->items[i].string); fprintf(stderr, _("\nPlease try\n\n" " git push --recurse-submodules=on-demand\n\n" "or cd to the path and use\n\n"
-- 2.10.0.rc1.1.g1ceb01a