Re: [PATCH 10/75] diff.h: avoid bit fields in struct diff_flags

From: Stefan Beller <sbeller@google.com>
Date: Jan 9, 2019, 20:21 UTC
Message-ID: <CAGZ79kagNUFYhe_juPrjWgGHGPdkow2+LjrUdXR84oNToh69kg@mail.gmail.com>
In-Reply-To: <20181227162536.15895-11-pclouds@gmail.com>

On Thu, Dec 27, 2018 at 8:26 AM Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 6 quoted lines

>
> Bitfield addresses cannot be passed around in a pointer. This makes it
> hard to use parse-options to set/unset them. Turn this struct to
> normal integers. This of course increases the size of this struct
> multiple times, but since we only have a handful of diff_options
> variables around, memory consumption is not at all a concern.

Makes sense, and continues 8cc633286a (Merge branch 'bw/diff-opt-impl-to-bitfields', 2017-11-09)

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.