From: Stefan Beller Date: Wed, 09 Jan 2019 20:21:54 GMT Subject: Re: [PATCH 10/75] diff.h: avoid bit fields in struct diff_flags Message-ID: In-Reply-To: <20181227162536.15895-11-pclouds@gmail.com> On Thu, Dec 27, 2018 at 8:26 AM Nguyễn Thái Ngọc Duy wrote: > > Bitfield addresses cannot be passed around in a pointer. This makes it > hard to use parse-options to set/unset them. Turn this struct to > normal integers. This of course increases the size of this struct > multiple times, but since we only have a handful of diff_options > variables around, memory consumption is not at all a concern. Makes sense, and continues 8cc633286a (Merge branch 'bw/diff-opt-impl-to-bitfields', 2017-11-09)