git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/75] diff.c: convert -u|-p|--patch

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Dec 27, 2018, 16:25 UTC
Message-ID
<20181227162536.15895-13-pclouds@gmail.com>
In-Reply-To
<20181227162536.15895-1-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 diff.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/diff.c b/diff.c
index a866f13c76..59132ceaff 100644
--- a/diff.c
+++ b/diff.c
@@ -4868,6 +4868,13 @@ static int parse_objfind_opt(struct diff_options *opt, const char *arg)
 static void prep_parse_options(struct diff_options *options)
 {
 	struct option parseopts[] = {
+		OPT_GROUP(N_("Diff output format options")),
+		OPT_BITOP('p', "patch", &options->output_format,
+			  N_("generate patch"),
+			  DIFF_FORMAT_PATCH, DIFF_FORMAT_NO_OUTPUT),
+		OPT_BITOP('u', NULL, &options->output_format,
+			  N_("generate patch"),
+			  DIFF_FORMAT_PATCH, DIFF_FORMAT_NO_OUTPUT),
 		OPT_END()
 	};
 
@@ -4896,8 +4903,7 @@ int diff_opt_parse(struct diff_options *options,
 		return ac;
 
 	/* Output format options */
-	if (!strcmp(arg, "-p") || !strcmp(arg, "-u") || !strcmp(arg, "--patch")
-	    || opt_arg(arg, 'U', "unified", &options->context))
+	if (opt_arg(arg, 'U', "unified", &options->context))
 		enable_patch_output(&options->output_format);
 	else if (!strcmp(arg, "--raw"))
 		options->output_format |= DIFF_FORMAT_RAW;
-- 
2.20.0.482.g66447595a7
Previous: Nguyễn Thái Ngọc Duy
Message 18 of 18 in “Convert diff opt parser to parse_options()”
  1. 00/75 Convert diff opt parser to parse_options()Nguyễn Thái Ngọc Duy, Dec 27, 2018
  2. 01/75 parse-options.h: remove extern on function prototypesNguyễn Thái Ngọc Duy, Dec 27, 2018
  3. 02/75 parse-options: add one-shot modeNguyễn Thái Ngọc Duy, Dec 27, 2018
  4. 04/75 parse-options: disable option abbreviation with PARSE_OPT_KEEP_UNKNOWNNguyễn Thái Ngọc Duy, Dec 27, 2018
  5. 03/75 parse-options: allow keep-unknown + stop-at-non-opt combinationNguyễn Thái Ngọc Duy, Dec 27, 2018
  6. 05/75 parse-options: add OPT_BITOP()Nguyễn Thái Ngọc Duy, Dec 27, 2018
  7. 07/75 parse-options: avoid magic return codesNguyễn Thái Ngọc Duy, Dec 27, 2018
  8. 06/75 parse-options: stop abusing 'callback' for lowlevel callbacksNguyễn Thái Ngọc Duy, Dec 27, 2018
  9. 08/75 parse-options: allow ll_callback with OPTION_CALLBACKNguyễn Thái Ngọc Duy, Dec 27, 2018
  10. 11/75 diff.c: prepare to use parse_options() for parsingNguyễn Thái Ngọc Duy, Dec 27, 2018
  11. 74/75 diff --no-index: use parse_options() instead of diff_opt_parse()Nguyễn Thái Ngọc Duy, Dec 27, 2018
  12. Eric SunshineDec 27, 2018
  13. 10/75 diff.h: avoid bit fields in struct diff_flagsNguyễn Thái Ngọc Duy, Dec 27, 2018
  14. Stefan BellerJan 9, 2019
  15. 75/75 am: avoid diff_opt_parse()Nguyễn Thái Ngọc Duy, Dec 27, 2018
  16. 73/75 range-diff: use parse_options() instead of diff_opt_parse()Nguyễn Thái Ngọc Duy, Dec 27, 2018
  17. 09/75 diff.h: keep forward struct declarations sortedNguyễn Thái Ngọc Duy, Dec 27, 2018
  18. 12/75 diff.c: convert -u|-p|--patchNguyễn Thái Ngọc Duy, Dec 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.