Re: [PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules

From: Stefan Beller <sbeller@google.com>
Date: Apr 13, 2017, 18:35 UTC
Message-ID: <CAGZ79kaRpAPFd8+rQUxKTmDfrQWdPGEEWGSVzstwUbj-7hRAKQ@mail.gmail.com>
In-Reply-To: <CA+P7+xr6zkb4kLTM-+0f5OTtt583WR_0j=NEebOdYuO3Z6h1+w@mail.gmail.com>

On Thu, Apr 13, 2017 at 11:31 AM, Jacob Keller <jacob.keller@gmail.com> wrote:

Show 5 quoted lines

> Spinning out a process is one of the big downsides of working with
> submodules in our code. Unfortunately, spinning out a process is also
> one of the biggest ways we isolate submodules, and if we wanted to do
> this "in-process" we would need to add an abstraction layer that lets
> us handle submodules in-process in some clean way.

Yeah if we had less globals and a repo struct (class) which we could operate on, that would be bring in the abstractions that we'd need.

Stefan