Re: [PATCH v2 1/2] ls-files: fix recurse-submodules with nested submodules
- From
- Brandon Williams <bmwill@google.com>
- Date
- Apr 13, 2017, 18:36 UTC
- Message-ID
- <20170413183615.GC96917@google.com>
- In-Reply-To
- <CAGZ79kaRpAPFd8+rQUxKTmDfrQWdPGEEWGSVzstwUbj-7hRAKQ@mail.gmail.com>
On 04/13, Stefan Beller wrote:
Show 9 quoted lines
> On Thu, Apr 13, 2017 at 11:31 AM, Jacob Keller <jacob.keller@gmail.com> wrote: > > Spinning out a process is one of the big downsides of working with > > submodules in our code. Unfortunately, spinning out a process is also > > one of the biggest ways we isolate submodules, and if we wanted to do > > this "in-process" we would need to add an abstraction layer that lets > > us handle submodules in-process in some clean way. > > Yeah if we had less globals and a repo struct (class) which we could > operate on, that would be bring in the abstractions that we'd need.
Agreed, though we're probably pretty far from that becoming a reality. One day though!
-- Brandon Williams