git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 17/28] attr: expose validity check for attribute names

From
Stefan Beller <sbeller@google.com>
Date
Oct 11, 2016, 18:44 UTC
Message-ID
<CAGZ79kaM_5MGwPPAhQKWgCGirbHvioBY7_PtkKxza8qV6ZyRnw@mail.gmail.com>
In-Reply-To
<20161011184010.GA16014@google.com>
On Tue, Oct 11, 2016 at 11:40 AM, Brandon Williams <bmwill@google.com> wrote:
> Wouldn't a +1 indicate that the attr name is valid while the 0
> indicates that it is invalid?
Right.
Show 8 quoted lines
>  It looks to me like we are checking each
> character and if we run into one that doesn't work then we have an error
> and return 0 indicating that the attr name we are checking is invalid,
> otherwise the name is valid and we would want to return a +1 indicating
> a success.
>
> Am I understanding the intent of this function properly?
>

I will change it to +1; I was just rambling about when you may expect -1 in this project. :)

Previous: Brandon WilliamsNext: Brandon Williams
Message 19 of 44 in “Revamping the attr subsystem!”
  1. 00/28 Revamping the attr subsystem!Stefan Beller, Oct 11, 2016
  2. 01/28 commit.c: use strchrnul() to scan for one lineStefan Beller, Oct 11, 2016
  3. 02/28 attr.c: use strchrnul() to scan for one lineStefan Beller, Oct 11, 2016
  4. 03/28 attr.c: update a stale comment on "struct match_attr"Stefan Beller, Oct 11, 2016
  5. 07/28 attr.c: simplify macroexpand_one()Stefan Beller, Oct 11, 2016
  6. 05/28 attr.c: complete a sentence in a commentStefan Beller, Oct 11, 2016
  7. 04/28 attr.c: explain the lack of attr-name syntax check in parse_attr()Stefan Beller, Oct 11, 2016
  8. 06/28 attr.c: mark where #if DEBUG ends more clearlyStefan Beller, Oct 11, 2016
  9. 09/28 attr.c: plug small leak in parse_attr_line()Stefan Beller, Oct 11, 2016
  10. 08/28 attr.c: tighten constness around "git_attr" structureStefan Beller, Oct 11, 2016
  11. 10/28 attr: rename function and struct related to checking attributesStefan Beller, Oct 11, 2016
  12. 14/28 attr: retire git_check_attrs() APIStefan Beller, Oct 11, 2016
  13. 13/28 attr: convert git_check_attrs() callers to use the new APIStefan Beller, Oct 11, 2016
  14. 16/28 attr: add counted string version of git_attr()Stefan Beller, Oct 11, 2016
  15. 17/28 attr: expose validity check for attribute namesStefan Beller, Oct 11, 2016
  16. Brandon WilliamsOct 11, 2016
  17. Stefan BellerOct 11, 2016
  18. Brandon WilliamsOct 11, 2016
  19. Stefan BellerOct 11, 2016
  20. Brandon WilliamsOct 11, 2016
  21. 15/28 attr: add counted string version of git_check_attr()Stefan Beller, Oct 11, 2016
  22. 19/28 attr.c: add push_stack() helperStefan Beller, Oct 11, 2016
  23. 18/28 attr: support quoting pathname patterns in C styleStefan Beller, Oct 11, 2016
  24. 21/28 attr.c: rename a local variable checkStefan Beller, Oct 11, 2016
  25. 25/28 attr.c: outline the future plans by heavily commentingStefan Beller, Oct 11, 2016
  26. 20/28 attr.c: pass struct git_attr_check down the callchainStefan Beller, Oct 11, 2016
  27. 26/28 attr: make git_attr_counted staticStefan Beller, Oct 11, 2016
  28. Brandon WilliamsOct 11, 2016
  29. Stefan BellerOct 11, 2016
  30. 27/28 attr: make git_check_attr_counted staticStefan Beller, Oct 11, 2016
  31. 23/28 attr.c: introduce empty_attr_check_elems()Stefan Beller, Oct 11, 2016
  32. 28/28 attr: convert to new threadsafe APIStefan Beller, Oct 11, 2016
  33. Brandon WilliamsOct 11, 2016
  34. Junio C HamanoOct 11, 2016
  35. Stefan BellerOct 11, 2016
  36. Junio C HamanoOct 11, 2016
  37. Stefan BellerOct 11, 2016
  38. Junio C HamanoOct 11, 2016
  39. 24/28 attr.c: always pass check[] to collect_some_attrs()Stefan Beller, Oct 11, 2016
  40. 22/28 attr.c: correct ugly hack for git_all_attrs()Stefan Beller, Oct 11, 2016
  41. 11/28 attr: (re)introduce git_check_attr() and struct git_attr_checkStefan Beller, Oct 11, 2016
  42. Brandon WilliamsOct 11, 2016
  43. Junio C HamanoOct 11, 2016
  44. 12/28 attr: convert git_all_attrs() to use "struct git_attr_check"Stefan Beller, Oct 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.