Re: [PATCH 2/3] rebase: Add tests for console output
- From
Stefan Beller <sbeller@google.com>
- Date
- Jun 1, 2017, 23:47 UTC
- Message-ID
- <CAGZ79kaM9ryT1gWx=L6S90HPCaDPNZ6H124HAJscpeJCQFDN8Q@mail.gmail.com>
- In-Reply-To
- <xmqq7f0v46q3.fsf@gitster.mtv.corp.google.com>
On Thu, Jun 1, 2017 at 4:40 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > >> Also, about the commit IDs. As long as the tests are consistent (i.e. they >> use test_commit rather than plain `git commit`, or at least call >> `test_tick` beforehand), the commit IDs should actually be identical >> between runs and not depend on the time of day or the date. >> >> The only exception to that rule is when some previous test cases call >> `test_commit` but are guarded behind some prereq and may not be executed >> at all. In that case, the precise commit IDs depend on the particular set >> of active prereqs. > > Good observation. The tests written such a way may make later > introduction of new hash function troublesome, though (we already > have tons of them, and it is already a hassle just imagining that we > will have to migrate them X-<). > > And what you gave below is an excellent suggestion to even solve > that future headaches. >
We had a discussion off list how much of the test suite is in bad shape, and "$ git grep ^index" points out a lot of places as well.