Re: [PATCH v3 0/4] Add regression tests for recent rebase -i fixes
- From
- Phillip Wood <phillip.wood@talktalk.net>
- Date
- Jun 26, 2017, 09:23 UTC
- Message-ID
- <5858ba2d-b88d-c2f1-2877-df0d1e8abc64@talktalk.net>
- In-Reply-To
- <xmqqmv8yedg0.fsf@gitster.mtv.corp.google.com>
On 23/06/17 20:01, Junio C Hamano wrote:
Show 7 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> For 3420, I can wrap the two-liner patch I showed here earlier into >> a commit on top of the series. > > So, here is what I'll queue on top before merging the topic down to > 'master'.
Thanks for creating this fixup, I'll remember to think about GETTEXT_POISON when I'm writing tests in the future.
Show 37 quoted lines
> -- >8 --
> Subject: [PATCH] t3420: fix under GETTEXT_POISON build
>
> Newly added tests to t3420 in this series prepare expected
> human-readable output from "git rebase -i" and then compare the
> actual output with it. As the output from the command is designed
> to go through i18n/l10n, we need to use test_i18ncmp to tell
> GETTEXT_POISON build that it is OK the output does not match.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> t/t3420-rebase-autostash.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t3420-rebase-autostash.sh b/t/t3420-rebase-autostash.sh
> index 6826c38cbd..e243700660 100755
> --- a/t/t3420-rebase-autostash.sh
> +++ b/t/t3420-rebase-autostash.sh
> @@ -178,7 +178,7 @@ testrebase () {
> test_when_finished git branch -D rebased-feature-branch &&
> suffix=${type#\ --} && suffix=${suffix:-am} &&
> create_expected_success_$suffix &&
> - test_cmp expected actual
> + test_i18ncmp expected actual
> '
>
> test_expect_success "rebase$type: dirty index, non-conflicting rebase" '
> @@ -275,7 +275,7 @@ testrebase () {
> test_when_finished git branch -D rebased-feature-branch &&
> suffix=${type#\ --} && suffix=${suffix:-am} &&
> create_expected_failure_$suffix &&
> - test_cmp expected actual
> + test_i18ncmp expected actual
> '
> }
>
>