Re: [PATCH] submodule: avoid sentence-lego in translated string

From: Stefan Beller <sbeller@google.com>
Date: Oct 9, 2017, 16:47 UTC
Message-ID: <CAGZ79ka7xo96MHaAUbkDuFjWMQaaD4j2UrRndcinAg6uzaP6Kw@mail.gmail.com>
In-Reply-To: <CAN0heSqFSiev8BeZVu3KBA5vswsbQrrOH=tYYOSs_h_eq=8-3Q@mail.gmail.com>

On Sun, Oct 8, 2017 at 9:14 PM, Martin Ågren <martin.agren@gmail.com> wrote:

> In this particular case, we could have three specific messages plus one default
> message (which at the time shouldn't ever occur). Or we have one specific
> message for the "tag"-case, which seems to have been Stefan's original
> motivation, and a generic message for the other cases.

I think the original patch is an improvement for the translations, but I'd really want to deliver as much information to the user, (it's an error message after all, so tell as much as possible that can be helpful,) which is why I would prefer to keep `typename(type)` in there.

I always assumed that translators are aware of these issues and sort of work around this somehow, maybe like this:

  "submodule entry '%s' (%s) is not a commit. It is of type %s"

Thanks, Stefan