Re: [PATCH] submodule: avoid sentence-lego in translated string
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Oct 9, 2017, 00:51 UTC
- Message-ID
- <20171009005137.4qwvkpedjslvbkca@genre.crustytoothpaste.net>
- In-Reply-To
- <8686C1FA80EF45099730B50235CAFF6F@PhilipOakley>
On Sun, Oct 08, 2017 at 10:32:35AM +0100, Philip Oakley wrote:
Show 9 quoted lines
> From: "Martin Ågren" <martin.agren@gmail.com>
> > - die(_("submodule entry '%s' (%s) is a %s, not a commit"),
> > - cb->path, oid_to_hex(oid), typename(type));
> > + die(_("submodule entry '%s' (%s) is not a commit"),
> > + cb->path, oid_to_hex(oid));
> Bikeshed,
> maybe:
> "submodule entry '%s' (%s) is not a commit. It is a %s"
> This puts the two parts in separate sentences?Languages with multiple grammatical genders are going to have problems with this. In French, "a tree" is "un arbre" (masculine), but "a tag" is "une étiquette" (feminine). We don't currently have a Spanish translation, but this would break there as well.
Splitting the article out with the type name is still problematic for languages where articles vary by case, like German, since the translation might be reused in another place requiring a different case.
-- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204