git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] path.c: implement xdg_config_home()

From
Stefan Beller <sbeller@google.com>
Date
Apr 14, 2015, 22:34 UTC
Message-ID
<CAGZ79kZvTdmGpoQozNjNefB4CWm31C05S1JoEBASFofxpYUXYg@mail.gmail.com>
In-Reply-To
<xmqqd2361gx8.fsf@gitster.dls.corp.google.com>

I need to learn to read the whole sentence. :( Apologies.

On Tue, Apr 14, 2015 at 3:30 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> On Tue, Apr 14, 2015 at 1:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>>> It is OK to omit the name in the extern declaration here.
>>
>> It is OK, but I think this is bad practice.
>
> Take a special note on the word "here", meaning "in this particular
> case."  It is perfectly fine when the meaning of the parameter is
> clear from its type.
>
> I was assuming that our developers have common sense to disambiguate
> ambiguous cases, of course ;-)
Previous: Junio C HamanoNext: Matthieu Moy
Message 24 of 26 in “path.c: implement xdg_config_home()”
  1. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 12, 2015
  2. 2/7 attr.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  3. 3/7 dir.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  4. 4/7 credential-store.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  5. 5/7 git-commit: replace use of home_config_paths()Paul Tan, Apr 12, 2015
  6. 6/7 git-config: replace use of home_config_paths()Paul Tan, Apr 12, 2015
  7. 7/7 path.c: remove home_config_paths()Paul Tan, Apr 12, 2015
  8. Johannes SchindelinApr 13, 2015
  9. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 14, 2015
  10. Eric SunshineApr 16, 2015
  11. Paul TanApr 18, 2015
  12. Eric SunshineApr 20, 2015
  13. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 21, 2015
  14. 2/7 attr.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  15. 3/7 dir.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  16. 4/7 credential-store.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  17. 5/7 git-commit: replace use of home_config_paths()Paul Tan, May 6, 2015
  18. 6/7 git-config: replace use of home_config_paths()Paul Tan, May 6, 2015
  19. 7/7 path.c: remove home_config_paths()Paul Tan, May 6, 2015
  20. Paul TanApr 18, 2015
  21. Junio C HamanoApr 14, 2015
  22. Stefan BellerApr 14, 2015
  23. Junio C HamanoApr 14, 2015
  24. Stefan BellerApr 14, 2015
  25. Matthieu MoyApr 13, 2015
  26. Stefan BellerApr 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.