git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/7] path.c: remove home_config_paths()

From
Paul Tan <pyokagan@gmail.com>
Date
Apr 12, 2015, 07:46 UTC
Message-ID
<1428824772-8736-7-git-send-email-pyokagan@gmail.com>
In-Reply-To
<1428824772-8736-1-git-send-email-pyokagan@gmail.com>

home_config_paths() combines distinct functionality already implemented by expand_user_path() and xdg_config_home(), and it also hard-codes the path ~/.gitconfig, which makes it unsuitable to use for other home config file paths. Since its use will just add unnecessary complexity to the code, remove it.

Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
 cache.h |  1 -
 path.c  | 28 ----------------------------
 2 files changed, 29 deletions(-)
diff --git a/cache.h b/cache.h
index 7f9bab0..19d75ef 100644
--- a/cache.h
+++ b/cache.h
@@ -816,7 +816,6 @@ enum scld_error safe_create_leading_directories(char *path);
 enum scld_error safe_create_leading_directories_const(const char *path);
 
 int mkdir_in_gitdir(const char *path);
-extern void home_config_paths(char **global, char **xdg, char *file);
 extern char *expand_user_path(const char *path);
 const char *enter_repo(const char *path, int strict);
 static inline int is_absolute_path(const char *path)
diff --git a/path.c b/path.c
index 4c32d16..84ec589 100644
--- a/path.c
+++ b/path.c
@@ -130,34 +130,6 @@ char *git_path(const char *fmt, ...)
 	return ret;
 }
 
-void home_config_paths(char **global, char **xdg, char *file)
-{
-	char *xdg_home = getenv("XDG_CONFIG_HOME");
-	char *home = getenv("HOME");
-	char *to_free = NULL;
-
-	if (!home) {
-		if (global)
-			*global = NULL;
-	} else {
-		if (!xdg_home) {
-			to_free = mkpathdup("%s/.config", home);
-			xdg_home = to_free;
-		}
-		if (global)
-			*global = mkpathdup("%s/.gitconfig", home);
-	}
-
-	if (xdg) {
-		if (!xdg_home)
-			*xdg = NULL;
-		else
-			*xdg = mkpathdup("%s/git/%s", xdg_home, file);
-	}
-
-	free(to_free);
-}
-
 char *git_path_submodule(const char *path, const char *fmt, ...)
 {
 	char *pathname = get_pathname();
-- 
2.1.4
Previous: Paul TanNext: Johannes Schindelin
Message 7 of 26 in “path.c: implement xdg_config_home()”
  1. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 12, 2015
  2. 2/7 attr.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  3. 3/7 dir.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  4. 4/7 credential-store.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  5. 5/7 git-commit: replace use of home_config_paths()Paul Tan, Apr 12, 2015
  6. 6/7 git-config: replace use of home_config_paths()Paul Tan, Apr 12, 2015
  7. 7/7 path.c: remove home_config_paths()Paul Tan, Apr 12, 2015
  8. Johannes SchindelinApr 13, 2015
  9. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 14, 2015
  10. Eric SunshineApr 16, 2015
  11. Paul TanApr 18, 2015
  12. Eric SunshineApr 20, 2015
  13. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 21, 2015
  14. 2/7 attr.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  15. 3/7 dir.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  16. 4/7 credential-store.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  17. 5/7 git-commit: replace use of home_config_paths()Paul Tan, May 6, 2015
  18. 6/7 git-config: replace use of home_config_paths()Paul Tan, May 6, 2015
  19. 7/7 path.c: remove home_config_paths()Paul Tan, May 6, 2015
  20. Paul TanApr 18, 2015
  21. Junio C HamanoApr 14, 2015
  22. Stefan BellerApr 14, 2015
  23. Junio C HamanoApr 14, 2015
  24. Stefan BellerApr 14, 2015
  25. Matthieu MoyApr 13, 2015
  26. Stefan BellerApr 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.