git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] git-config: replace use of home_config_paths()

From
Paul Tan <pyokagan@gmail.com>
Date
Apr 12, 2015, 07:46 UTC
Message-ID
<1428824772-8736-6-git-send-email-pyokagan@gmail.com>
In-Reply-To
<1428824772-8736-1-git-send-email-pyokagan@gmail.com>

Since home_config_paths() combines distinct functionality already implemented by expand_user_path() and xdg_config_home(), and hides the home config file path ~/.gitconfig. Make the code more explicit by replacing the use of home_config_paths() with expand_user_path() and xdg_config_home().

Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
 builtin/config.c | 6 ++----
 config.c         | 6 ++----
 2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/builtin/config.c b/builtin/config.c
index d32c532..5e61f4a 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -488,10 +488,8 @@ int cmd_config(int argc, const char **argv, const char *prefix)
 	}
 
 	if (use_global_config) {
-		char *user_config = NULL;
-		char *xdg_config = NULL;
-
-		home_config_paths(&user_config, &xdg_config, "config");
+		char *user_config = expand_user_path("~/.gitconfig");
+		char *xdg_config = xdg_config_home("config");
 
 		if (!user_config)
 			/*
diff --git a/config.c b/config.c
index 66c0a51..3a619da 100644
--- a/config.c
+++ b/config.c
@@ -1185,10 +1185,8 @@ int git_config_system(void)
 int git_config_early(config_fn_t fn, void *data, const char *repo_config)
 {
 	int ret = 0, found = 0;
-	char *xdg_config = NULL;
-	char *user_config = NULL;
-
-	home_config_paths(&user_config, &xdg_config, "config");
+	char *xdg_config = xdg_config_home("config");
+	char *user_config = expand_user_path("~/.gitconfig");
 
 	if (git_config_system() && !access_or_die(git_etc_gitconfig(), R_OK, 0)) {
 		ret += git_config_from_file(fn, git_etc_gitconfig(),
-- 
2.1.4
Previous: Paul TanNext: Paul Tan
Message 6 of 26 in “path.c: implement xdg_config_home()”
  1. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 12, 2015
  2. 2/7 attr.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  3. 3/7 dir.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  4. 4/7 credential-store.c: replace home_config_paths() with xdg_config_home()Paul Tan, Apr 12, 2015
  5. 5/7 git-commit: replace use of home_config_paths()Paul Tan, Apr 12, 2015
  6. 6/7 git-config: replace use of home_config_paths()Paul Tan, Apr 12, 2015
  7. 7/7 path.c: remove home_config_paths()Paul Tan, Apr 12, 2015
  8. Johannes SchindelinApr 13, 2015
  9. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 14, 2015
  10. Eric SunshineApr 16, 2015
  11. Paul TanApr 18, 2015
  12. Eric SunshineApr 20, 2015
  13. 1/7 path.c: implement xdg_config_home()Paul Tan, Apr 21, 2015
  14. 2/7 attr.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  15. 3/7 dir.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  16. 4/7 credential-store.c: replace home_config_paths() with xdg_config_home()Paul Tan, May 6, 2015
  17. 5/7 git-commit: replace use of home_config_paths()Paul Tan, May 6, 2015
  18. 6/7 git-config: replace use of home_config_paths()Paul Tan, May 6, 2015
  19. 7/7 path.c: remove home_config_paths()Paul Tan, May 6, 2015
  20. Paul TanApr 18, 2015
  21. Junio C HamanoApr 14, 2015
  22. Stefan BellerApr 14, 2015
  23. Junio C HamanoApr 14, 2015
  24. Stefan BellerApr 14, 2015
  25. Matthieu MoyApr 13, 2015
  26. Stefan BellerApr 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.