git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] convert submodule.c to not use the index compat macros

From
Stefan Beller <sbeller@google.com>
Date
Dec 12, 2017, 20:08 UTC
Message-ID
<CAGZ79kZsTduEsrC-BWOuT6Y+QGn_SLngO4Fs78q2N8Rp+xnhCg@mail.gmail.com>
In-Reply-To
<20171212195352.146675-1-bmwill@google.com>
On Tue, Dec 12, 2017 at 11:53 AM, Brandon Williams <bmwill@google.com> wrote:
> This series removes the remaining users of the index compatibility macros and
> ensures that future uses of the macros will result in compiler errors.

Thanks for converting the submodule code to avoid these old macros. Specifically the submodule code will benefit once we have a repository object available throughout the code base, so it is a great start.

I reviewed the series and would call out patch 2 to be a bugfix that could go independently, but the whole series is fine as-is with me.

Thanks, Stefan

Previous: Brandon WilliamsNext: Junio C Hamano
Message 6 of 8 in “convert submodule.c to not use the index compat macros”
  1. 0/3 convert submodule.c to not use the index compat macrosBrandon Williams, Dec 12, 2017
  2. 1/3 submodule: convert stage_updated_gitmodules to take a struct index_stateBrandon Williams, Dec 12, 2017
  3. 2/3 submodule: used correct index in is_staging_gitmodules_okBrandon Williams, Dec 12, 2017
  4. Eric SunshineDec 12, 2017
  5. 3/3 submodule: convert get_next_submodule to not rely on the_indexBrandon Williams, Dec 12, 2017
  6. Stefan BellerDec 12, 2017
  7. Junio C HamanoDec 12, 2017
  8. Junio C HamanoDec 12, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.