git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] submodule: used correct index in is_staging_gitmodules_ok

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 12, 2017, 20:17 UTC
Message-ID
<CAPig+cTtFB8ZyqF994TLbEj0Km930W3C758niCXNH5v3=hW5Cw@mail.gmail.com>
In-Reply-To
<20171212195352.146675-3-bmwill@google.com>
On Tue, Dec 12, 2017 at 2:53 PM, Brandon Williams <bmwill@google.com> wrote:
> Commit 883e248b8 (fsmonitor: teach git to optionally utilize a file
> system monitor to speed up detecting new or changed files., 2017-09-22)
> introduced a call to 'ce_match_stat()' in 'is_staging_gitmodules_ok()'
> which implicitly relys on the the global 'the_index' instead of the
s/relys/relies/
> passed in 'struct index_state'.  Fix this by changing the call to
> 'ie_match_stat()' and using the passed in index_state struct.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
Previous: Brandon WilliamsNext: Brandon Williams
Message 4 of 8 in “convert submodule.c to not use the index compat macros”
  1. 0/3 convert submodule.c to not use the index compat macrosBrandon Williams, Dec 12, 2017
  2. 1/3 submodule: convert stage_updated_gitmodules to take a struct index_stateBrandon Williams, Dec 12, 2017
  3. 2/3 submodule: used correct index in is_staging_gitmodules_okBrandon Williams, Dec 12, 2017
  4. Eric SunshineDec 12, 2017
  5. 3/3 submodule: convert get_next_submodule to not rely on the_indexBrandon Williams, Dec 12, 2017
  6. Stefan BellerDec 12, 2017
  7. Junio C HamanoDec 12, 2017
  8. Junio C HamanoDec 12, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.