From: Stefan Beller <sbeller@google.com>
Date: Tue, 12 Dec 2017 20:08:59 GMT
Subject: Re: [PATCH 0/3] convert submodule.c to not use the index compat macros
Message-ID: <CAGZ79kZsTduEsrC-BWOuT6Y+QGn_SLngO4Fs78q2N8Rp+xnhCg@mail.gmail.com>
In-Reply-To: <20171212195352.146675-1-bmwill@google.com>

On Tue, Dec 12, 2017 at 11:53 AM, Brandon Williams <bmwill@google.com> wrote:
> This series removes the remaining users of the index compatibility macros and
> ensures that future uses of the macros will result in compiler errors.

Thanks for converting the submodule code to avoid these old macros.
Specifically the submodule code will benefit once we have a repository
object available throughout the code base, so it is a great start.

I reviewed the series and would call out patch 2 to be a bugfix that could
go independently, but the whole series is fine as-is with me.

Thanks,
Stefan